Skip to content

CLN: Remove Unneeded BlockManager methods #22002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2018

Conversation

jbrockmendel
Copy link
Member

BlockManager.get_scalar is never used outside of tests,
BlockManager._is_indexed_like is only ever called from merge, which is only called once in Panel, before which the indexed_like check is already done.

Also BlockPlacements.iadd was more complicated than it needed to be, so tore out bits of that.

@codecov
Copy link

codecov bot commented Jul 21, 2018

Codecov Report

Merging #22002 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22002      +/-   ##
==========================================
- Coverage      92%   91.99%   -0.01%     
==========================================
  Files         170      170              
  Lines       50609    50594      -15     
==========================================
- Hits        46561    46546      -15     
  Misses       4048     4048
Flag Coverage Δ
#multiple 90.4% <ø> (-0.01%) ⬇️
#single 42.2% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 96.47% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171076c...4504ccf. Read the comment docs.

@gfyoung gfyoung added Internals Related to non-user accessible pandas implementation Clean labels Jul 23, 2018
@jorisvandenbossche jorisvandenbossche changed the title [CLN] Remove Unneeded BlockManager methods CLN: Remove Unneeded BlockManager methods Jul 26, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 26, 2018
@jreback jreback merged commit 7110a34 into pandas-dev:master Jul 26, 2018
@jreback
Copy link
Contributor

jreback commented Jul 26, 2018

thanks, always +1 on removing code!

@jbrockmendel jbrockmendel deleted the indexed_like branch July 26, 2018 16:20
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants